bin/cookies: Drop libsoup code, fix fd-relative issues, new style
authorColin Walters <walters@verbum.org>
Mon, 17 Jul 2017 22:05:25 +0000 (18:05 -0400)
committerAtomic Bot <atomic-devel@projectatomic.io>
Tue, 18 Jul 2017 19:07:56 +0000 (19:07 +0000)
commit9430b8ad75b5a17cdd05ca3e4eeab1a6302c6f63
treef5e8b2ae8118a5f6a9f55236c5f1068d6041a4e8
parente0346c149498a7ec7d5c064a9d5485c9dcb693b1
bin/cookies: Drop libsoup code, fix fd-relative issues, new style

Prep for `ostree_repo_new_at()`. These commands were directly accessing
`repo->repodir`, which it turns out was unnecessary since the the APIs they then
used were fd-relative. Except actually there were bugs there, so fix all of the
cookie util code to actually use the passed `dfd` and not just hardcode
`AT_FDCWD`.

Also, libsoup can't handle this (its APIs require fully qualifed paths), and
there's not a really good reason to have two implementations now; historically
it was useful to cross-check them, but I don't think we need that.

While I'm here, port to new style.

Closes: #1010
Approved by: jlebon
src/ostree/ot-remote-builtin-add-cookie.c
src/ostree/ot-remote-builtin-delete-cookie.c
src/ostree/ot-remote-builtin-list-cookies.c
src/ostree/ot-remote-cookie-util.c